-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate hpc_load() and integrate it with restore() #7955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7955 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 203 203
Lines 13129 13125 -4
======================================
- Hits 12017 11974 -43
- Misses 1112 1151 +39 |
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-14 11:54:07 UTC |
for more information, see https://pre-commit.ci
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may use this wrapper but otherwise it looks food to me https://github.com/Borda/pyDeprecate#simple-function-forwarding
What does this PR do?
Part of #7652
CheckpointConnector.hpc_load()
does the same thing asCheckpointConnector()
, except it additionally calls a hookon_hpc_load on the module. This hook calling is now taken care of in
restore()
.Now we can properly deprecate the hpc_load for
restore()
to remove the code duplication.The unit tests added here ensure that
restore()
behaves the same as the deprecatedhpc_load
!Also closes #5371
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃