Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate hpc_load() and integrate it with restore() #7955

Merged
merged 15 commits into from
Jun 14, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 12, 2021

What does this PR do?

Part of #7652

CheckpointConnector.hpc_load() does the same thing as CheckpointConnector(), except it additionally calls a hook
on_hpc_load on the module. This hook calling is now taken care of in restore().
Now we can properly deprecate the hpc_load for restore() to remove the code duplication.

The unit tests added here ensure that restore() behaves the same as the deprecated hpc_load!

Also closes #5371

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #7955 (017e36a) into master (20a5e09) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7955   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         203     203           
  Lines       13129   13125    -4     
======================================
- Hits        12017   11974   -43     
- Misses       1112    1151   +39     

@pep8speaks
Copy link

pep8speaks commented Jun 12, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-14 11:54:07 UTC

@awaelchli awaelchli added this to the v1.4 milestone Jun 12, 2021
@awaelchli awaelchli marked this pull request as ready for review June 12, 2021 17:27
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 14, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 14, 2021 10:27
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may use this wrapper but otherwise it looks food to me https://github.com/Borda/pyDeprecate#simple-function-forwarding

@awaelchli awaelchli merged commit 6b7b404 into master Jun 14, 2021
@awaelchli awaelchli deleted the feature/resume-8 branch June 14, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants