Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate moved warning functions #8085

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Keep BC for users importing these utility functions from the specific distributed.py file

To be included in the 1.3.8 release

Closes #8084

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the feature Is an improvement or enhancement label Jun 22, 2021
@carmocca carmocca added this to the v1.3.x milestone Jun 22, 2021
@carmocca carmocca self-assigned this Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #8085 (e4e38bb) into master (f79f0f9) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8085    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         210     210            
  Lines       13617   13617            
=======================================
- Hits        12488   11846   -642     
- Misses       1129    1771   +642     

@carmocca carmocca merged commit 6dd7797 into master Jun 22, 2021
@carmocca carmocca deleted the bugfix/deprecate-warnings-fns branch June 22, 2021 22:09
awaelchli added a commit that referenced this pull request Jun 23, 2021
awaelchli added a commit that referenced this pull request Jun 23, 2021
awaelchli added a commit that referenced this pull request Jun 23, 2021
lexierule pushed a commit that referenced this pull request Jun 23, 2021
@Lightning-AI Lightning-AI deleted a comment from 0833347379 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants