Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove metric deprecation message at module import level #8163

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 28, 2021

What does this PR do?

Every Lightning user who imports PL, whether they want torchmetrics or not, are getting this warning.
It makes no sense to print a warning and import it ourselves one level higher up in pytorch_lightning/__init__.py

All functions in the metrics package are already decorated with a deprecation warning message.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jun 28, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #8163 (99a95ab) into master (c3065c5) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8163    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         211     211            
  Lines       13440   13438     -2     
=======================================
- Hits        12450   11829   -621     
- Misses        990    1609   +619     

@awaelchli awaelchli marked this pull request as ready for review June 28, 2021 08:31
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 28, 2021
@awaelchli awaelchli requested a review from Borda June 28, 2021 08:36
@mergify mergify bot requested a review from a team June 28, 2021 08:59
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 😃

@SkafteNicki SkafteNicki enabled auto-merge (squash) June 28, 2021 09:36
@SkafteNicki SkafteNicki merged commit b978d2a into master Jun 28, 2021
@SkafteNicki SkafteNicki deleted the bugfix/metrics-spam branch June 28, 2021 09:57
awaelchli added a commit that referenced this pull request Jun 29, 2021
awaelchli added a commit that referenced this pull request Jun 29, 2021
awaelchli added a commit that referenced this pull request Jun 30, 2021
awaelchli added a commit that referenced this pull request Jul 1, 2021
lexierule pushed a commit that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants