Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up tests/test_profiler.py #867

Merged
merged 2 commits into from
Feb 19, 2020
Merged

clean up tests/test_profiler.py #867

merged 2 commits into from
Feb 19, 2020

Conversation

jeremyjordan
Copy link
Contributor

Continuation of #837

@jeremyjordan jeremyjordan mentioned this pull request Feb 17, 2020
Merged
@jeremyjordan jeremyjordan requested a review from Borda February 17, 2020 17:27
@Borda
Copy link
Member

Borda commented Feb 17, 2020 •
edited
Loading

The tailing test was fixed in #873, pls rebase master

Borda
Borda approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@Borda Borda added bug Something isn't working docs Documentation related ready PRs ready to be merged labels Feb 17, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 17, 2020
@jeremyjordan jeremyjordan force-pushed the tests/profiler-cleanup branch from df68ebd to c491808 Compare February 17, 2020 20:18
@williamFalcon williamFalcon merged commit ea8878b into Lightning-AI:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
bug Something isn't working docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyjordan @Borda @williamFalcon