Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_from_checkpoint docs #978

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

neggert
Copy link
Contributor

@neggert neggert commented Feb 28, 2020

We don't (yet) support storing hparams a a dict. It must
be an argparse.Namespace for checkpoint saving and
loading to work.

Also opened #977 to start supporting this, but lets fix the docs for now.

We don't (yet) support storing hparams a a dict. It *must*
be an `argparse.Namespace` for checkpoint saving and
loading to work.
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda added docs Documentation related ready PRs ready to be merged labels Feb 28, 2020
@Borda Borda added this to the 0.7.0 milestone Feb 28, 2020
@williamFalcon williamFalcon merged commit 94afe82 into Lightning-AI:master Feb 29, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
We don't (yet) support storing hparams a a dict. It *must*
be an `argparse.Namespace` for checkpoint saving and
loading to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants