Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update logos #2021

Merged
merged 2 commits into from
Aug 24, 2023
Merged

docs: update logos #2021

merged 2 commits into from
Aug 24, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 23, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2021.org.readthedocs.build/en/2021/

@Borda Borda added the documentation Improvements or additions to documentation label Aug 23, 2023
@Borda Borda requested a review from a team August 23, 2023 19:11
@Borda Borda enabled auto-merge (squash) August 23, 2023 19:15
@Borda Borda requested a review from williamFalcon August 23, 2023 20:23
@mergify mergify bot added the ready label Aug 23, 2023
@Borda Borda disabled auto-merge August 23, 2023 21:08
@Borda Borda marked this pull request as draft August 23, 2023 21:08
@mergify mergify bot removed the ready label Aug 23, 2023
@Borda
Copy link
Member Author

Borda commented Aug 24, 2023

we need to double-check the rendering in docs, see: Lightning-AI/pytorch-lightning#18375 (comment)

@Borda Borda marked this pull request as ready for review August 24, 2023 21:24
@Borda Borda merged commit 5ed0f83 into master Aug 24, 2023
@Borda Borda deleted the docs/logo branch August 24, 2023 21:24
@mergify mergify bot added the ready label Aug 24, 2023
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants