Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: switch away from deprecated jiwer methods #2937

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

nikvaessen
Copy link
Contributor

@nikvaessen nikvaessen commented Feb 3, 2025

What does this PR do?

Fixes your tests breaking when you accidentally upgrade to version v4.0.0.


📚 Documentation preview 📚: https://torchmetrics--2937.org.readthedocs.build/en/2937/

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs bumping min version or jiwer, right?

@Borda Borda changed the title feat: switch away from deprecated jiwer methods tests: switch away from deprecated jiwer methods Feb 3, 2025
@Borda Borda changed the title tests: switch away from deprecated jiwer methods tests: switch away from deprecated jiwer methods Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39%. Comparing base (e874f4e) to head (425affb).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e874f4e) and HEAD (425affb). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (e874f4e) HEAD (425affb)
gpu 3 0
unittest 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2937      +/-   ##
=========================================
- Coverage      99%     39%     -61%     
=========================================
  Files          14     332     +318     
  Lines         176   18996   +18820     
=========================================
+ Hits          175    7377    +7202     
- Misses          1   11619   +11618     

@Borda Borda merged commit 2283831 into Lightning-AI:master Feb 3, 2025
57 of 64 checks passed
@mergify mergify bot added the ready label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants