Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert torchvision dependency and write tests for cifar10 #858

Closed
wants to merge 0 commits into from

Conversation

BaruchG
Copy link
Contributor

@BaruchG BaruchG commented Aug 8, 2022

What does this PR do?

Wrote unit test for the CIFAR10 dataset and made the dataset import from torchvision to reduce code redundancy as outlined in #839.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
    Draft proposal since TrialCifar10 explicitly states that it should not rely on torchvision and this PR makes CIFAR10 a torchvision dependency.

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@otaj otaj mentioned this pull request Aug 12, 2022
@@ -1,9 +1,20 @@
import pytest
import torch

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh it didn't merge cleanly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@otaj
Copy link
Contributor

otaj commented Sep 16, 2022

Hi @BaruchG, can I ask why was this closed?

@BaruchG
Copy link
Contributor Author

BaruchG commented Sep 20, 2022

Sorry @otaj, I was having some issues with my github version and this somehow got deleted. The branch is now up again at https://github.com/BaruchG/lightning-bolts/tree/cifar until we decide on what to do with hard torchvision dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants