Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test on multiple ruby versions. #113

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

barakwei
Copy link
Member

Currently, the tests were running on ruby 2.6 and using latest
RubyGems. This is broken since latest RubyGems support Ruby>3. This is
fine since ruby 2.7 is now deprecated.

Kintsugi runs usually on macOS which comes built-in with ruby 2.6, so
it's worth keep testing on that version. So this commit add tests on
multiple ruby versions.

Currently, the tests were running on ruby 2.6 and using latest
RubyGems. This is broken since latest RubyGems support Ruby>3. This is
fine since ruby 2.7 is now deprecated.

Kintsugi runs usually on macOS which comes built-in with ruby 2.6, so
it's worth keep testing on that version. So this commit add tests on
multiple ruby versions.
@barakwei
Copy link
Member Author

@byohay we can add head version also.

Copy link
Collaborator

@byohay byohay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Not sure head is necessary if we anyway provide specific versions.
Let's open another PR to fix the release action to use another ruby version. Maybe there we can use head

@barakwei barakwei merged commit 04e48f0 into Lightricks:main Dec 29, 2023
4 checks passed
@barakwei barakwei deleted the feature/remove-rubygems-fix branch December 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants