kintsugi: Handle expected errors gracefully. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byohay
force-pushed
the
feature/handle-errors-gracefully
branch
4 times, most recently
from
98329f8 to
fdf500a
Compare
ashdnazg
suggested changes
Dec 16, 2021
lib/kintsugi/error.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| module Kintsugi | ||
| class EnvironmentError < RuntimeError |
There was a problem hiding this comment.
Removed EnvironmentError
| class EnvironmentError < RuntimeError | ||
| end | ||
|
|
||
| class MergeError < RuntimeError |
byohay
force-pushed
the
feature/handle-errors-gracefully
branch
from
fdf500a to
b949db5
Compare
|
@ashdnazg squashed. |
ashdnazg
approved these changes
Dec 16, 2021
lib/kintsugi.rb
Outdated
| # @raise [RuntimeError] | ||
| # If no rebase, cherry-pick, or merge is in progress, or the project file couldn't be | ||
| # opened, or there was an error applying the change to the project. | ||
| # @raise [EnvironmentError] |
There was a problem hiding this comment.
Suggested change
| # @raise [EnvironmentError] | |
| # @raise [ArgumentError] |
Instead of printing the stack trace, just print the errors.
byohay
force-pushed
the
feature/handle-errors-gracefully
branch
from
b949db5 to
33023b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing the stack trace, just print the errors.