feat: added public addresses with failover #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsen3d
approved these changes
Sep 16, 2024
narbs91
reviewed
Sep 16, 2024
pkg/web3/sdk.go
Outdated
| @@ -229,7 +238,8 @@ func NewContractSDK(options Web3Options) (*Web3SDK, error) { | |||
| TransactOpts: transactOpts, | |||
| Contracts: contracts, | |||
| } | |||
| log.Debug().Msgf("Public Address: %s", web3SDK.GetAddress()) | |||
| // fmt.Printf("Public Address: %s\n", web3SDK.GetAddress()) | |||
There was a problem hiding this comment.
Thank you @narbs91, I removed the commented code.
narbs91
approved these changes
Sep 17, 2024
noryev
force-pushed
the
feat-public-RPC-with-failover
branch
from
00ebd4d to
c24eebc
Compare
noryev
force-pushed
the
feat-public-RPC-with-failover
branch
from
c24eebc to
0d09857
Compare
hunjixin
reviewed
Sep 17, 2024
| var client *ethclient.Client | ||
| var err error | ||
| for _, url := range rpcs { | ||
| client, err = ethclient.Dial(url) |
There was a problem hiding this comment.
using dial is useless for select available rpc. since arb not check cu when connect.
my sugesstion is to use module like index := address%len(rpcsClients). or a more simple way to use random select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
We are saturating our RPC endpoint. This fix uses a public rpc with a failover
Task/Issue reference
Closes: add_link_here
Test plan
These modifications were tested using my local GPU RP on the lilypad testnet- as a lilypad resource provider
Details (optional)
Add any additional details that will help to review this pull request.
Related issues or PRs (optional)
Add any related issues or PRs.