Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/000 e2e test config #738

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Feature/000 e2e test config #738

merged 1 commit into from
Sep 16, 2022

Conversation

trayanm
Copy link
Contributor

@trayanm trayanm commented Sep 16, 2022

Signed-off-by: Trayan Manolov [email protected]

  • add node scenario for test scenario specific options (expectedValidatorsCount, firstEvmChainId, secondEvmChainId)
    Change e2e config parser to support config scenario
    Change e2e_test to use config scenario

Detailed description:

Which issue(s) this PR fixes:
Fixes #735

Special notes for your reviewer:
After merge, everyone should update their ./e2e/setup/application.yml file with scenario node. For example:

scenario:
  expectedValidatorsCount: 3
  firstEvmChainId: 80001
  secondEvmChainId: 43113

Checklist

  • Documentation added
  • Tests updated

@trayanm trayanm force-pushed the feature/000-e2e-test-config branch from 0980f09 to be3429b Compare September 16, 2022 06:52
e2e/e2e_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #738 (62ad3a4) into main (5f5c9ed) will not change coverage.
The diff coverage is n/a.

❗ Current head 62ad3a4 differs from pull request most recent head f7dad16. Consider uploading reports for the commit f7dad16 to get more accurate results

@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files          78       78           
  Lines        5676     5676           
=======================================
  Hits         3608     3608           
  Misses       1896     1896           
  Partials      172      172           
Flag Coverage Δ
unittests 63.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rokn
rokn previously approved these changes Sep 16, 2022
@trayanm trayanm force-pushed the feature/000-e2e-test-config branch 2 times, most recently from f0dbf05 to 62ad3a4 Compare September 16, 2022 07:41
svetlio8
svetlio8 previously approved these changes Sep 16, 2022
…specific options (expectedValidatorsCount, firstEvmChainId, secondEvmChainId) Change e2e config parser to support config scenario Change e2e_test to use config scenario

Update docs/testing.md

Remove comments from e2e/e2e_test.go

Signed-off-by: trayanm <[email protected]>
@trayanm trayanm merged commit 4c9eafb into main Sep 16, 2022
@trayanm trayanm deleted the feature/000-e2e-test-config branch September 16, 2022 11:26
svetlio8 pushed a commit that referenced this pull request Sep 30, 2022
…specific options (expectedValidatorsCount, firstEvmChainId, secondEvmChainId) Change e2e config parser to support config scenario Change e2e_test to use config scenario (#738)

Update docs/testing.md

Remove comments from e2e/e2e_test.go

Signed-off-by: trayanm <[email protected]>

Signed-off-by: trayanm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants