Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new retry library for MirrorNode client #768

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add new retry library for MirrorNode client #768

merged 1 commit into from
Nov 17, 2022

Conversation

rokn
Copy link
Contributor

@rokn rokn commented Nov 16, 2022

Signed-off-by: Antonio Mindov [email protected]

Detailed description:
This introduces a new retry library for the MirrorNode client which handles retries in a better way.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #768 (1c60d9b) into main (1fa70be) will decrease coverage by 0.37%.
The diff coverage is 36.00%.

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   63.84%   63.46%   -0.38%     
==========================================
  Files          78       78              
  Lines        5709     5691      -18     
==========================================
- Hits         3645     3612      -33     
- Misses       1893     1908      +15     
  Partials      171      171              
Flag Coverage Δ
unittests 63.46% <36.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/helper/http/retry-logger.go 0.00% <0.00%> (ø)
app/clients/hedera/mirror-node/client.go 48.45% <100.00%> (-0.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rokn rokn merged commit 0b7311a into main Nov 17, 2022
@rokn rokn deleted the feature/retry-lib branch November 17, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants