feat(901): log node url when operation fails #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 64.05% 64.11% +0.05%
==========================================
Files 86 86
Lines 6696 6707 +11
==========================================
+ Hits 4289 4300 +11
Misses 2195 2195
Partials 212 212
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rokn
previously approved these changes
Aug 9, 2023
app/clients/evm/client_pool.go
Outdated
| func (cp *ClientPool) getClient(idx int) client.EVM { | ||
| return cp.clients[idx%len(cp.clients)] | ||
| func (cp *ClientPool) getClient(idx int) (client.EVM, config.Evm) { | ||
| return cp.clients[idx%len(cp.clients)], cp.clientsConfigs[idx%len(cp.clientsConfigs)] |
There was a problem hiding this comment.
nit: I'd extract the index in a var to improve readability
rokn
approved these changes
Aug 9, 2023
asenslime
force-pushed
the
feature/log-rpc-client
branch
2 times, most recently
from
b107240 to
ae6a505
Compare
Signed-off-by: Asen Prodanov <[email protected]>
asenslime
force-pushed
the
feature/log-rpc-client
branch
from
ae6a505 to
9137bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
log node url when operation fails
Which issue(s) this PR fixes:
Fixes #901
Special notes for your reviewer:
Checklist