Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test host_manager is running in the container #414

Merged
merged 4 commits into from
Aug 13, 2024
Merged

test host_manager is running in the container #414

merged 4 commits into from
Aug 13, 2024

Conversation

Yuhu-kth
Copy link
Collaborator

No description provided.

Limmen
Limmen requested changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@Limmen Limmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one print statement to remove

emulation-system/tests/test_start_host_manager.py Outdated
try:
container_setup.reload()
assert container_setup.status == "running", f"Container {container_setup.name} is not running"
print(f"Container {container_setup} is running.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this print

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@Yuhu-kth
Copy link
Collaborator Author

Yuhu-kth commented Aug 13, 2024 •
edited
Loading

For the start_host_manager test, 30 containers in total, 29 passed, 1 didn't pass because its not running, don't know why it's not running yet.
Info:

Error occurred in container beautiful_khayyam: 409 Client Error for http+docker://localhost/v1.42/containers/b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1/exec: Conflict ("Container b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1 is not running")
Containers that failed to start the host manager:
{'container_id': 'b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1', 'name': 'beautiful_khayyam', 'error': '409 Client Error for http+docker://localhost/v1.42/containers/b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1/exec: Conflict ("Container b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1 is not running")'}

@Limmen
Copy link
Owner

Limmen commented Aug 13, 2024

For the start_host_manager test, 30 containers in total, 29 passed, 1 didn't pass because its not running, don't know why it's not running yet. Info:

Error occurred in container beautiful_khayyam: 409 Client Error for http+docker://localhost/v1.42/containers/b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1/exec: Conflict ("Container b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1 is not running") Containers that failed to start the host manager: {'container_id': 'b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1', 'name': 'beautiful_khayyam', 'error': '409 Client Error for http+docker://localhost/v1.42/containers/b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1/exec: Conflict ("Container b396c1ac63ad324137db0b0ac4c2ee565ecd9a2375451ea71d64e8457aa014b1 is not running")'}

Which container image is it ?

@Limmen Limmen merged commit 1322f77 into master Aug 13, 2024
@Limmen Limmen deleted the host_manager branch August 14, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Limmen Limmen Limmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuhu-kth @Limmen