This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Added onBeforeShow callback #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have somehow missed this in the documentation, please feel free to give me a hard time. :)
If not, I added an
onBeforeShowcallback. This is particularly useful if I need to prepare parts of the interface before showing a step. For example, I needed the ability to open an off-canvas drawer before showing the steps within that drawer so the steps would be properly positioned.As the name implies, this callback will fire before
onShowand before any set delay begins. I also wrote a simple test to make sure it fires.It was useful for me so I thought I'd create a pull request and see if it was also useful for anyone else.