Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic titles are weird #23

Closed
MathisP75 opened this issue Sep 23, 2024 · 5 comments
Closed

Automatic titles are weird #23

MathisP75 opened this issue Sep 23, 2024 · 5 comments
Labels
enhancement Enhancing the existing features

Comments

@MathisP75
Copy link

Automatic titles seem to be very hit or miss compared to Google Keep. Sometimes I get the generic website name only: Screenshot_20240923-082850.png

Screenshot_20240923-082914.png

Sometimes, I get weird stuff, like this Reddit title in an unknown language:Screenshot_20240923-082827.png

Screenshot_20240923-082815.png

@sakethpathike
Copy link
Member

I've also noticed the issue with Reddit and other sites.

Titles and images are scraped from the website's meta tags in the HTML, so as long as they're present, the app will "fetch" them.

I'm not quite sure how Keep handles this, but I'll look into it soon.

@sakethpathike sakethpathike added the enhancement Enhancing the existing features label Sep 23, 2024
@cris16228
Copy link

Automatic titles seem to be very hit or miss compared to Google Keep. Sometimes I get the generic website name only: Screenshot_20240923-082850.png

Screenshot_20240923-082914.png

Sometimes, I get weird stuff, like this Reddit title in an unknown language:Screenshot_20240923-082827.png

Screenshot_20240923-082815.png

The latter with reddit is because he's using a simple html parser library.
Dm'd the dev. Hoping to hear back for updates!

Edit: Both your problems are the one I've said above

@sakethpathike
Copy link
Member

sakethpathike commented Sep 27, 2024

Hello, @MathisP75, try changing the user agent to Twitterbot/1.0 in the app settings and reloading the link info. This should fix most title and image detection issues. However, some images, especially from Reddit, might not load as expected. I will fix this soon.

@MathisP75
Copy link
Author

That did it, thank you!

@sakethpathike
Copy link
Member

This has been fixed in v0.8.2: https://github.com/sakethpathike/Linkora/releases/tag/release-v0.8.2.

Thanks for raising this issue, @MathisP75!

@cris16228 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing the existing features
Projects
None yet
Development

No branches or pull requests

3 participants