Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add LIP "Introduce BFT module" #113

Merged
merged 18 commits into from
Nov 30, 2021
Merged

Add LIP "Introduce BFT module" #113

merged 18 commits into from
Nov 30, 2021

Conversation

janhack
Copy link
Contributor

@janhack janhack commented Sep 27, 2021

No description provided.

@janhack janhack self-assigned this Sep 27, 2021
Copy link
Contributor

@MaximeGagnebin MaximeGagnebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only left a few typo style comments and updates for the merged LIPs. Nice job!

proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
@janhack
Copy link
Contributor Author

janhack commented Oct 1, 2021

I addressed the review comments and there were some changes resulting from the BFT module implementation, see LiskArchive/lisk-sdk#6742. I therefore re-requested the reviews.

proposals/lip-introduce_bft_module.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaximeGagnebin MaximeGagnebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Alessandro Ricottone <[email protected]>
@janhack janhack requested a review from karmacoma October 6, 2021 10:07
@shuse2 shuse2 changed the base branch from master to main October 21, 2021 15:26
@janhack janhack removed the request for review from karmacoma November 4, 2021 09:50
@janhack janhack requested a review from karmacoma November 8, 2021 08:41
@karmacoma karmacoma merged commit 47f586f into main Nov 30, 2021
@karmacoma karmacoma deleted the jan-introduce_bft_module branch November 30, 2021 14:23
sergeyshemyakov pushed a commit that referenced this pull request Apr 20, 2022
Preparatory changes for the flat ecosystem
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants