Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update to doc for the new on-chain architecture #728

Merged
merged 11 commits into from
Sep 29, 2020
Merged

Update to doc for the new on-chain architecture #728

merged 11 commits into from
Sep 29, 2020

Conversation

IkerAlus
Copy link
Contributor

@IkerAlus IkerAlus commented Sep 15, 2020 •
edited
Loading

changes to the following sections:

  • accounts
  • transactions
  • mainnet

@IkerAlus IkerAlus added protocol type: update Existing content, that needs to be updated labels Sep 15, 2020
@IkerAlus IkerAlus self-assigned this Sep 15, 2020
@IkerAlus
Update transactions.adoc
5fb809e
@IkerAlus
update transactions 2.0
aa1b341 
- change name of transactions
- moduleID and assetId
- extra info for delegate registration
@IkerAlus
Update accounts.adoc
9cf9a7f 
- mention the four modules
- link each of the properties with their respective module
- update transaction names
@IkerAlus
update account diagram
9a87ac5
@IkerAlus
update transaction diagrams
049f226
@IkerAlus IkerAlus requested a review from janhack September 16, 2020 09:14
janhack
janhack suggested changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments and maybe double-check with Shu regarding the wording related to modules.

@IkerAlus IkerAlus requested a review from janhack September 23, 2020 08:29
janhack
janhack suggested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, there are a few open comments left.

@IkerAlus IkerAlus requested a review from janhack September 24, 2020 15:43
janhack
janhack approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

@janhack janhack linked an issue Sep 25, 2020 that may be closed by this pull request
Update protocol documentation to reflect on-chain architecture changes. #752
Closed
@IkerAlus IkerAlus requested a review from Tschakki September 29, 2020 07:00
@Tschakki Tschakki merged commit 04a519d into docs-protocol Sep 29, 2020
@Tschakki Tschakki deleted the iker_onchain-updates branch January 13, 2021 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@janhack janhack janhack approved these changes

@Tschakki Tschakki Awaiting requested review from Tschakki

Assignees

@IkerAlus IkerAlus

Labels
type: update Existing content, that needs to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update protocol documentation to reflect on-chain architecture changes.
4 participants
@IkerAlus @shuse2 @janhack @Tschakki