Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update application to support on-chain architecture #5611

Closed
shuse2 opened this issue Aug 4, 2020 · 0 comments
Closed

Update application to support on-chain architecture #5611

shuse2 opened this issue Aug 4, 2020 · 0 comments

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 4, 2020

Description

  • Add register module in application
    • registerModule(ModuleClass, { moduleType });
    • All actions and events which are defined in each module should be accessible through “moduleName:actionName” or “moduleName:event”.
    • If moduleType is not specified, it should use the module type specified in the module.
    • Remove registerTransaction
  • Rename “getForgerAddressesForRound” to “getValidators”
  • Add static function defaultApplication() which returns application instance with registered default modules
  • Move genesis JSON parsing to node.bootstrap
  • Move networkIdentifier calculation to node after genesis block parsing
  • Update getSchema return value to include module and asset types
  • Register action and events from the modules to channel
  • Update getRegisteredTransactionFee to use genesis config

Prefix should be:
getForgersInfoForActiveRound -> app:getDelegates

Motivation

Module needs to be registered to the application and accessible from the plugins.

Acceptance criteria

  • Modules are passed to the node.ts
  • Actions and events are accessible through channel
  • Update application unit test
  • Check genesis block parsing happens after registration of module

Related Issues

#5603

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants