Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix outdated lisk-coded protocol spec #5647

Closed
shuse2 opened this issue Aug 12, 2020 · 0 comments
Closed

Fix outdated lisk-coded protocol spec #5647

shuse2 opened this issue Aug 12, 2020 · 0 comments
Assignees
@shuse2
Labels
protocol-spec type: bug unplanned
Milestone
Sprint 25

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Aug 12, 2020

Expected behavior

Transaction type should be migrated to moduleType and assetType for codec tests to work.

Actual behavior

Some transaction type was remaining in the protocol spec, and make codec tests to fail

Steps to reproduce

cd elements/lisk-codec; npm t

Which version(s) does this affect? (Environment, OS, etc...)

5.0-
@shuse2 shuse2 self-assigned this Aug 12, 2020
@shuse2 shuse2 added this to the Sprint 25 milestone Aug 12, 2020
@shuse2 shuse2 mentioned this issue Aug 12, 2020
Merged
shuse2 added a commit that referenced this issue Aug 12, 2020
@shuse2
Merge pull request #5648 from LiskHQ/5647-udpate_protocol_spec
464da22 
Fix outdated lisk-coded protocol spec - Closes #5647
@shuse2 shuse2 closed this as completed Aug 12, 2020
@shuse2 shuse2 mentioned this issue Aug 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
protocol-spec type: bug unplanned
Projects
None yet
Milestone
Sprint 25
Development

No branches or pull requests
1 participant
@shuse2