Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement Reward Module endpoint #6689

Closed
mehmetegemen opened this issue Aug 25, 2021 · 0 comments · Fixed by #6751
Closed

Implement Reward Module endpoint #6689

mehmetegemen opened this issue Aug 25, 2021 · 0 comments · Fixed by #6751
Assignees
@mehmetegemen
Labels
framework groomed type: improvement unplanned
Milestone
Sprint 52

Comments

@mehmetegemen
Copy link
Contributor

mehmetegemen commented Aug 25, 2021 •
edited by shuse2
Loading

Description

Implement getDefaultRewardAtHeight function as specified in https://research.lisk.com/t/define-state-transitions-of-reward-module/316#getdefaultrewardatheight-18 in endpoint.ts file and implement endpoint in reward module class.

Acceptance Criteria

  • getDefaultRewardAtHeight function is implemented and unit tested.

Additional Information

  • Reward brackets(milestones) are taken from moduleConfig.brackets
  • rewardOffset and rewardDistance are taken from the config parameter in the init method of the reward class

Related Issue

#6686
@mehmetegemen mehmetegemen mentioned this issue Aug 25, 2021
Closed
@shuse2 shuse2 added this to the Sprint 52 milestone Sep 2, 2021
@mehmetegemen mehmetegemen self-assigned this Sep 8, 2021
@mehmetegemen mehmetegemen mentioned this issue Sep 8, 2021
Merged
@shuse2 shuse2 linked a pull request Sep 8, 2021 that will close this issue
Add reward module endpoint - Closes #6689 #6751
Merged
shuse2 added a commit that referenced this issue Sep 9, 2021
@shuse2
Merge pull request #6751 from LiskHQ/6689-reward-endpoint
d50cfd7 
Add reward module endpoint - Closes #6689
@shuse2 shuse2 closed this as completed Sep 9, 2021
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mehmetegemen mehmetegemen

Labels
framework groomed type: improvement unplanned
Projects
None yet
Milestone
Sprint 52
Development

Successfully merging a pull request may close this issue.

Add reward module endpoint - Closes #6689 LiskArchive/lisk-sdk
3 participants
@shuse2 @mehmetegemen @sridharmeganathan