Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement appendToInboxTree function #7041

Closed
Tracked by #6915
mitsuaki-u opened this issue Feb 23, 2022 · 0 comments · Fixed by #7085
Closed
Tracked by #6915

Implement appendToInboxTree function #7041

mitsuaki-u opened this issue Feb 23, 2022 · 0 comments · Fixed by #7085
Assignees
@Incede
Labels
framework/module/interoperability Interoperability module
Milestone
Sprint 65

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Feb 23, 2022 •
edited
Loading

Description

appendToInboxTree internal function is required in interoperability module:

appendToInboxTree(chainID, appendData):
    # Update root, appendPath, and size
    let inboxTree be the underlying Merkle tree of channel(chainID).inbox
    inboxTree.append(SHA-256(appendData))
    channel(chainID).inbox.root = inboxTree.root
    channel(chainID).inbox.appendPath = inboxTree.appendPath
    channel(chainID).inbox.size = inboxTree.size

    return True

Acceptence Criteria

  • Add unit test for appendToInboxTree
@ishantiw ishantiw added framework/module/interoperability Interoperability module and removed framework labels Feb 23, 2022
@mitsuaki-u mitsuaki-u mentioned this issue Feb 23, 2022
Closed
30 tasks
@mitsuaki-u mitsuaki-u changed the title Implement appendToInboxTree internal function Implement appendToInbox and appendToInboxTree functions Feb 23, 2022
@mitsuaki-u mitsuaki-u changed the title Implement appendToInbox and appendToInboxTree functions Implement addToInbox and appendToInboxTree functions Feb 23, 2022
@mitsuaki-u mitsuaki-u changed the title Implement addToInbox and appendToInboxTree functions Implement appendToInboxTree functions Feb 24, 2022
@mitsuaki-u mitsuaki-u changed the title Implement appendToInboxTree functions Implement appendToInboxTree function Feb 24, 2022
@milenagojkovic milenagojkovic added this to the Sprint 64 milestone Feb 28, 2022
@shuse2 shuse2 moved this from Backlog to ToDo in Lisk SDK Version 6.0.0 Feb 28, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 64, Sprint 65 Mar 14, 2022
@Incede Incede self-assigned this Mar 23, 2022
@milenagojkovic milenagojkovic moved this from ToDo to In Progress in Lisk SDK Version 6.0.0 Mar 23, 2022
@Incede Incede mentioned this issue Mar 24, 2022
Merged
@Incede Incede moved this from In Progress to Pending Review in Lisk SDK Version 6.0.0 Mar 24, 2022
ishantiw added a commit that referenced this issue Mar 25, 2022
@ishantiw
Merge pull request #7085 from LiskHQ/7041-append-inbox
3e4b65d 
 Implement appendToInboxTree function - Closes #7041
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Mar 25, 2022
@shuse2 shuse2 linked a pull request Mar 28, 2022 that will close this issue
Implement appendToInboxTree function - Closes #7041 #7085
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Incede Incede

Labels
framework/module/interoperability Interoperability module
Projects
None yet
Milestone
Sprint 65
Development

Successfully merging a pull request may close this issue.

Implement appendToInboxTree function - Closes #7041 LiskArchive/lisk-sdk
4 participants
@milenagojkovic @ishantiw @Incede @mitsuaki-u