Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing static block header validation #7058

Closed
shuse2 opened this issue Feb 28, 2022 · 0 comments · Fixed by #7068
Closed

Missing static block header validation #7058

shuse2 opened this issue Feb 28, 2022 · 0 comments · Fixed by #7068

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Feb 28, 2022

Expected behavior

Instead of relying on the internal cryptography library, the length check for the signature should be done explicitly in the chain library Block.

Actual behavior

The signature length check is internally done in the verifyData function

Steps to reproduce

N/A

Which version(s) does this affect? (Environment, OS, etc...)

development

@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Feb 28, 2022
@shuse2 shuse2 added this to the Sprint 64 milestone Feb 28, 2022
@milenagojkovic milenagojkovic moved this from Backlog to ToDo in Lisk SDK Version 6.0.0 Feb 28, 2022
@Incede Incede self-assigned this Mar 10, 2022
@Incede Incede moved this from ToDo to In Progress in Lisk SDK Version 6.0.0 Mar 10, 2022
@Incede Incede moved this from In Progress to Pending Review in Lisk SDK Version 6.0.0 Mar 10, 2022
@milenagojkovic milenagojkovic modified the milestones: Sprint 64, Sprint 65 Mar 14, 2022
shuse2 added a commit that referenced this issue Mar 17, 2022
 Missing static block header validation - Closes #7058
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants