This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Merge Feature/create network module #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peerHeaders are updated
…whenever the system info changes
…he current peer system
Integrate @liskhq/lisk-p2p module in chain module - Closes #2874
…eracting with peers directly
pablitovicente
previously approved these changes
Apr 29, 2019
michielmulders
previously approved these changes
Apr 29, 2019
| @@ -101,7 +103,7 @@ describe('Integration tests for P2P library', () => { | |||
| // Set a different discoveryInterval for each node; that way they don't keep trying to discover each other at the same time. | |||
| discoveryInterval: DISCOVERY_INTERVAL + index * 11, | |||
| nodeInfo: { | |||
| wsPort: NETWORK_START_PORT + index, | |||
| wsPort: nodePort, | |||
There was a problem hiding this comment.
Possibly rename the variable to wsPort for clarity (at line 94)?
There was a problem hiding this comment.
And other places as well, just minor that can be considered.
…skHQ/lisk-sdk into feature/create_network_module
shuse2
dismissed stale reviews from michielmulders and pablitovicente
via
a7a21e4
… feature/create_network_module
ishantiw
previously approved these changes
Apr 29, 2019
pablitovicente
previously approved these changes
Apr 29, 2019
nazarhussain
suggested changes
Apr 29, 2019
nazarhussain
previously approved these changes
Apr 29, 2019
… feature/create_network_module
shuse2
requested review from
ishantiw,
pablitovicente,
nazarhussain and
michielmulders
and removed request for
nazarhussain
pablitovicente
approved these changes
Apr 29, 2019
ishantiw
approved these changes
Apr 29, 2019
jondubois
approved these changes
Apr 29, 2019
| @@ -194,6 +174,25 @@ module.exports = class Chain { | |||
|
|
|||
| self.logger.info('Modules ready and launched'); | |||
|
|
|||
| this.channel.subscribe( | |||
| 'network:subscribe', | |||
There was a problem hiding this comment.
This name still doesn't seem quite right. We should raise another issue to adjust the naming.
There was a problem hiding this comment.
Actually we can use this existing issue: #3263
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging feature/create_network_module
In the new network module, internally it uses lisk-p2p library.
Any of the interaction directly to the peer is removed from chain, and it's handled within the network module.