Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement reward module API - Closes #6688 #6782

Merged
merged 10 commits into from
Sep 17, 2021
Merged

Implement reward module API - Closes #6688 #6782

merged 10 commits into from
Sep 17, 2021

Conversation

mehmetegemen
Copy link
Contributor

What was the problem?

This PR resolves #6688

How was it solved?

  • Added getBlockReward function and injected configs for its usage

How was it tested?

  • Tested with unit tests created in this PR

@mehmetegemen mehmetegemen requested a review from shuse2 September 16, 2021 14:36
@mehmetegemen mehmetegemen self-assigned this Sep 16, 2021
@shuse2 shuse2 requested a review from mitsuaki-u September 16, 2021 15:05
shuse2
shuse2 suggested changes Sep 16, 2021
View reviewed changes
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/reward/api.spec.ts Outdated Show resolved Hide resolved
shuse2
shuse2 approved these changes Sep 17, 2021
View reviewed changes
framework/src/modules/reward/api.ts
return BigInt(0);
}

const defaultReward = calculateDefaultReward({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create an issue to test this function for

  • before/at/after the distance height + offset
    I see the only before offset for this function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuse2 shuse2 merged commit 83f0d6b into feature/6554-improve-framework-architecture Sep 17, 2021
@shuse2 shuse2 deleted the 6688-reward-api branch September 17, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@mehmetegemen mehmetegemen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetegemen @shuse2 @mitsuaki-u