This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Rename properties on lisk-transactions - Closes #6631 and #6632 #6831
Merged
shuse2
merged 7 commits into
feature/6554-improve-framework-architecture
from
6631-update-lisk-transactions
Oct 15, 2021
Merged
Rename properties on lisk-transactions - Closes #6631 and #6632 #6831
shuse2
merged 7 commits into
feature/6554-improve-framework-architecture
from
6631-update-lisk-transactions
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd08752
to
fb5a2be
Compare
ishantiw
reviewed
Oct 13, 2021
address: address.toString('hex'), | ||
}); | ||
} catch (error) { | ||
throw new Error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error could also be auth module not found or some other error? so maybe more generic error, Unsupported application. Either module or action name does not exist
…update-lisk-transactions
Incede
approved these changes
Oct 15, 2021
…update-lisk-transactions
ishantiw
approved these changes
Oct 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6631 and resolves #6632
How was it solved?
:
to_
How was it tested?
asset
name is gone