Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Bootstrap cross chain command classes - Closes #7024 #7094

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Mar 30, 2022

What was the problem?

This PR resolves #7024

How was it solved?

🌱 Bootstrap cross chain commands 960102f

  • Bootstrap CCCommands classes for mainchain and sidechains
  • Add related schemas
  • Add related constants

How was it tested?

Check if all the relevant files, schemas and constants are present

- boostrap CCCommands classes for mainchain and sidechains
- Add related schemas
- Add related constants
@ishantiw ishantiw self-assigned this Mar 30, 2022
@ishantiw ishantiw requested review from mitsuaki-u and shuse2 March 30, 2022 13:14
@ishantiw ishantiw linked an issue Mar 30, 2022 that may be closed by this pull request
@ishantiw ishantiw linked an issue Mar 30, 2022 that may be closed by this pull request
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

export const channelTerminatedCCMParamsSchema = {
$id: 'modules/interoperability/ccCommand/channelTerminated',
type: 'object',
properties: {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is suppose to be empty object, but if we assign empty object to the schema = {} then it shows error coz schema type has some required properties

@ishantiw ishantiw merged commit 14287fc into feature/6915-introduce-interoperability-module Apr 1, 2022
@ishantiw ishantiw deleted the 7024-bootstrap-cc-command-classes branch April 1, 2022 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap cross chain commands for mainchain/sidechain modules
3 participants