This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update token module and transfer command - Closes #7117 and #7118 #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the title
This was
linked to
issues
Apr 25, 2022
shuse2
changed the title
shuse2
force-pushed
the
7117-update_token_module
branch
from
5630234 to
c2b90ff
Compare
shuse2
commented
Apr 26, 2022
| @@ -231,4 +264,31 @@ export class TokenAPI extends BaseAPI { | |||
| return prev; | |||
| }, BigInt(0)); | |||
| } | |||
|
|
|||
| public async isNative(apiContext: ImmutableAPIContext, tokenID: TokenID): Promise<boolean> { | |||
There was a problem hiding this comment.
Added isNative for fee module to check if chainID is native or not
|
|
||
| import { CHAIN_ID_ALIAS_NATIVE, CHAIN_ID_LENGTH, TOKEN_ID_LENGTH } from './constants'; | ||
| import { TokenID } from './types'; | ||
|
|
There was a problem hiding this comment.
util functions for handling store key and token ID format
| }, | ||
| required: ['address'], | ||
| required: ['address', 'tokenID'], | ||
| }; | ||
|
|
||
| export const transferParamsSchema = { |
There was a problem hiding this comment.
Updated schema, and add restriction on schema. This is used in the validation
| @@ -59,7 +67,11 @@ export class TokenModule extends BaseModule { | |||
| const genesisStore = codec.decode<GenesisTokenStore>(genesisTokenStoreSchema, assetBytes); | |||
| const userStore = context.getStore(this.id, STORE_PREFIX_USER); | |||
| for (const userData of genesisStore.userSubstore) { | |||
| await userStore.setWithSchema(userData.address, userData, userStoreSchema); | |||
| await userStore.setWithSchema( | |||
| getUserStoreKey(userData.address, userData.tokenID), | |||
There was a problem hiding this comment.
Temporally update the genesis block handling. Proper implementation will be done in #7119
| @@ -52,26 +63,38 @@ export class TokenAPI extends BaseAPI { | |||
| apiContext: APIContext, | |||
| senderAddress: Buffer, | |||
| recipientAddress: Buffer, | |||
| _tokenID: TokenID, | |||
| tokenID: TokenID, | |||
There was a problem hiding this comment.
this transfer function is the main change. Other API will be properly implemented in #7122
| import { BaseCommand } from '../../base_command'; | ||
| import { CommandExecuteContext } from '../../../node/state_machine'; | ||
| import { |
There was a problem hiding this comment.
this command is the main file updated
shuse2
force-pushed
the
7117-update_token_module
branch
from
ec09f11 to
0f68d97
Compare
MaximeGagnebin
suggested changes
Apr 27, 2022
shuse2
force-pushed
the
7117-update_token_module
branch
from
51bd1db to
3110c5f
Compare
mitsuaki-u
reviewed
May 5, 2022
MaximeGagnebin
approved these changes
May 6, 2022
mitsuaki-u
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7117 and #7118
How was it solved?
How was it tested?