Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations.js to add Chinese (Simplified) and Chinese (Traditional) #116

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

lakejason0
Copy link
Contributor

I'm using this greeter theme starting today because I hate to have a functional GNOME while actually using KDE (sddm has some bug so I had to give up). It's a really nice lightdm theme, but it can be better to have Chinese support!
I don't know whether it supports language fallback (because there are many "variants" of Chinese, and all of them eventually can be split into Simplified and Traditional). That is, "zh_Hant" "zh_TW" "zh_HK" (idk if there's more in Linux locale) should use "zh_TW" texts in the translation. "zh_CN" (and if there's "zh_Hans" or more Linux locale) should use "zh_CN" texts in the translation. "zh" is for fallback of Chinese, and idk if I should actually set this to any of them, but by default in MediaWiki "zh" is fallback to "zh_CN".
Hope that you can accept my pull request.

@lakejason0
Copy link
Contributor Author

Also, Chinese doesn't (I even should use "never") use italic text, because it would cause a legibility issue. Though I have a relatively big screen and the text size is relatively big in the theme, it might still be a problem. I'll appreciate it if you can look into the problem but this is totally another problem.

@Litarvan Litarvan merged commit 964aa03 into Litarvan:master Apr 19, 2021
@Litarvan
Copy link
Owner

I edited the theme so that when chinese is detected, the usage of italic is disabled text :)
Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants