-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract audio conversion to a separate function and add output logs if conversion fails #10
Conversation
good work on the log functionality. But the codec option will create problem. If some other format is specified then this would cause the output file extension will be OK but the data format will NOT be OK. I would appreciate if you can write a general function which implements this. Something Like |
Moved to The tests are failing for unrelated reasons. |
Also, if we remove fmdpy/.github/workflows/integrate.yaml Line 19 in e7492a2
Looks like that is causing the failed tests. |
Are you ready to merge ? I have made a shadow branch in which the CI tests is working. The CI test is failing because of the lack of the ffmpeg API key in your repo. |
If you do add more commits, pls change the target branch from |
I'm ready to merge...I tested this for a while and it's working well for me for various formats. Feel free to merge this. Thanks!! |
Following up on our discussion in #9, I extracted the ffmpeg conversion process in a separate function and added logging if conversion fails.
Let me know what you think.