This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
CM-848: Setup CodeQL #119
Merged
CM-848: Setup CodeQL #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
SuperIzya
reviewed
Jun 13, 2023
| @@ -0,0 +1,3 @@ | |||
| paths: | |||
| - src | |||
| - rollup | |||
There was a problem hiding this comment.
I saw there are some alerts in test
https://github.com/LiveIntent/live-connect/security/code-scanning
and then I thought it should be ok to not scan tests. but I can put it back and then we can fix the issues
There was a problem hiding this comment.
Can we put a comment in code for CodeQL to skip next line? I would prefer to be aware there is smth fishy with tests...
There was a problem hiding this comment.
I couldn't find a way how to do it, but I will put the test back and we can dismiss the alert as it is used in Test in that case.. At least we will be aware of that.
3link
reviewed
Jun 13, 2023
3link
approved these changes
Jun 14, 2023
SuperIzya
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-848
Remove lgtm and setup CodeQL
Author Todo List:
Ready For Reviewstatus