This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
CM-1181 - Send page URL to the identity resolution endpoint #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschuwalow
reviewed
Mar 11, 2024
src/pixel/url-collector.ts
Outdated
| @@ -29,6 +29,17 @@ export function collectUrl(state: UrlState): [string, boolean, string[]] { | |||
| return [url.toString(), pathRemoved, blockedParams] | |||
| } | |||
|
|
|||
| export function stripQueryAndPath(pageUrl?: string): string { | |||
There was a problem hiding this comment.
Empty string will be stripped by the query builder default. In case this is the desired behaviour, I propose more explicitly communicating that in the types by returning undefined
There was a problem hiding this comment.
Yes, desired behaviour. Changed the signature to stripQueryAndPath(pageUrl: string): string and the impl uses onNonNull now.
mschuwalow
reviewed
Mar 11, 2024
mschuwalow
reviewed
Mar 11, 2024
src/idex.ts
Outdated
| @@ -59,6 +62,7 @@ export class IdentityResolver { | |||
| .addOptional('gpp_as', nonNullConfig.gppApplicableSections?.join(',')) | |||
| .addOptional('cd', nonNullConfig.cookieDomain) | |||
| .addOptional('ic', encodeIdCookie(nonNullConfig.resolvedIdCookie), { stripEmpty: false }) | |||
| .addOptional('pu', stripQueryAndPath(nonNullConfig.pageUrl)) | |||
There was a problem hiding this comment.
This is fine, but if you want your helper function to only deal with non nullable types, there is a onNonNull helper you could use
mschuwalow
approved these changes
Mar 11, 2024
wi101
approved these changes
Mar 11, 2024
peixunzhang
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the page URL to the identity resolution endpoint. This is helpful in cases where the origin header is not available.
Author Todo List:
Ready For Reviewstatus