Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: Move skip check before call to Youtube-DL #204

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

zdimension
Copy link
Collaborator

@zdimension zdimension commented Nov 7, 2023

Description

Before, the skip check was done in add_media, i.e. after the call to process_youtube. As a result, even for media for which Themerr had already downloaded a theme, Youtube-DL was still called to try and get the stream URL, which

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #204 (0ff67b1) into nightly (dadf374) will decrease coverage by 1.93%.
The diff coverage is 44.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #204      +/-   ##
===========================================
- Coverage    68.98%   67.06%   -1.93%     
===========================================
  Files           10       10              
  Lines          748      759      +11     
===========================================
- Hits           516      509       -7     
- Misses         232      250      +18     
Flag Coverage Δ
Linux 67.06% <44.44%> (?)
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/constants.py 86.11% <100.00%> (+0.39%) ⬆️
Contents/Code/plex_api_helper.py 47.79% <41.17%> (-4.88%) ⬇️

Co-authored-by: ReenigneArcher <[email protected]>
@ReenigneArcher ReenigneArcher merged commit d04fad4 into LizardByte:nightly Nov 8, 2023
22 of 23 checks passed
@zdimension zdimension deleted the fix-skip-check branch November 8, 2023 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants