Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

build(deps): Bump youtube-dl and add as a submodule #300

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 17, 2023

Description

Add youtube-dl as submodule. This "should" allow dependabot to keep it updated.

Todo:

  • change patches to git apply ... method
  • document patch process

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build(deps)-add-youtube-dl-as-submodule branch from 6c7a88a to 9625cb1 Compare December 17, 2023 23:22
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #300 (4d2318b) into master (3cc4ad5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   69.68%   69.68%           
=======================================
  Files          12       12           
  Lines         983      983           
=======================================
  Hits          685      685           
  Misses        298      298           
Flag Coverage Δ
Linux 69.68% <ø> (ø)
Windows 69.48% <ø> (-0.21%) ⬇️
macOS 69.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the build(deps)-add-youtube-dl-as-submodule branch 3 times, most recently from 28cd4f6 to 643ed7d Compare December 17, 2023 23:40
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 17, 2023 23:42
@ReenigneArcher ReenigneArcher force-pushed the build(deps)-add-youtube-dl-as-submodule branch 2 times, most recently from 43affe6 to da4adcc Compare December 17, 2023 23:46
@ReenigneArcher ReenigneArcher force-pushed the build(deps)-add-youtube-dl-as-submodule branch from da4adcc to 4d2318b Compare December 17, 2023 23:51
@ReenigneArcher ReenigneArcher changed the title build(deps): add youtube-dl as submodule build(deps): Bump youtube-dl and add as a submodule Dec 17, 2023
@ReenigneArcher ReenigneArcher merged commit c6019c5 into master Dec 18, 2023
21 checks passed
@ReenigneArcher ReenigneArcher deleted the build(deps)-add-youtube-dl-as-submodule branch December 18, 2023 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant