Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(locale): compile web ui translations and enable additional languages #391

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 16, 2024

Description

This PR fixes an issue where translations were not compiled for the web UI, and adds some additional logging.

Additionally, Swedish and Chinese Simplified will be enabled.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix(locale)-compile-web-ui-translations branch 2 times, most recently from f22f181 to 67b9c89 Compare March 16, 2024 00:10
@ReenigneArcher ReenigneArcher changed the title fix(locale): compile web ui translations fix(locale): compile web ui translations and enable additional languages Mar 16, 2024
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 16, 2024 00:11
@ReenigneArcher ReenigneArcher force-pushed the fix(locale)-compile-web-ui-translations branch 2 times, most recently from 95b1ffb to a972506 Compare March 16, 2024 00:29
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (f08199a) to head (93e734d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   71.46%   71.52%   +0.05%     
==========================================
  Files          12       12              
  Lines        1083     1085       +2     
==========================================
+ Hits          774      776       +2     
  Misses        309      309              
Flag Coverage Δ
Linux 71.52% <100.00%> (+0.05%) ⬆️
Windows 71.52% <100.00%> (+0.05%) ⬆️
macOS 71.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/webapp.py 68.12% <100.00%> (+0.40%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix(locale)-compile-web-ui-translations branch from a972506 to ca7ab7b Compare March 16, 2024 01:02
@ReenigneArcher ReenigneArcher force-pushed the fix(locale)-compile-web-ui-translations branch from ca7ab7b to 93e734d Compare March 16, 2024 16:15
@ReenigneArcher ReenigneArcher merged commit 9d6a497 into master Mar 16, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(locale)-compile-web-ui-translations branch March 16, 2024 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant