Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): resolve issue when @ symbol appears earlier in entry than the contributor #112

Conversation

ReenigneArcher
Copy link
Member

Description

In some cases the @ symbol could appear earlier in the line, causing the regex to fail to find the username.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (a5aef49) to head (c8f7f3b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   98.68%   98.69%           
=======================================
  Files           1        1           
  Lines         152      153    +1     
=======================================
+ Hits          150      151    +1     
  Misses          2        2           
Files Coverage Δ
action/main.py 98.69% <100.00%> (+<0.01%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix(changelog)-resolve-issue-when-`@`-symbol-appears-earlier-in-entry-than-the-contributor branch from 225998e to bdcb46d Compare July 16, 2024 02:31
@ReenigneArcher ReenigneArcher force-pushed the fix(changelog)-resolve-issue-when-`@`-symbol-appears-earlier-in-entry-than-the-contributor branch from bdcb46d to c8f7f3b Compare July 16, 2024 02:35
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 16, 2024 02:37
@ReenigneArcher ReenigneArcher merged commit fd48baa into master Jul 16, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(changelog)-resolve-issue-when-`@`-symbol-appears-earlier-in-entry-than-the-contributor branch July 16, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant