Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove key error when running on non pull request #6

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

The action would fail if the event was not a pull request. This PR fixes that.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #6 (c016f11) into master (d3bcebf) will increase coverage by 35.55%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   57.97%   93.52%   +35.55%     
===========================================
  Files           1        1               
  Lines         138      139        +1     
===========================================
+ Hits           80      130       +50     
+ Misses         58        9       -49     
Files Coverage Δ
action/main.py 93.52% <100.00%> (+35.55%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix-remove-key-error-when-running-on-non-pull-request branch from 034e068 to 7aac38d Compare October 21, 2023 15:34
@ReenigneArcher ReenigneArcher force-pushed the fix-remove-key-error-when-running-on-non-pull-request branch from 7aac38d to c016f11 Compare October 21, 2023 15:48
@ReenigneArcher ReenigneArcher merged commit eadca4f into master Oct 21, 2023
@ReenigneArcher ReenigneArcher deleted the fix-remove-key-error-when-running-on-non-pull-request branch October 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant