module: add prometheus-node-exporter service #1129
Merged
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
node-exporter
branch
from
404c7a9 to
5a68aa6
Compare
emilazy
requested changes
Oct 30, 2024
mweinelt
force-pushed
the
node-exporter
branch
2 times, most recently
from
1ec7f5d to
f349f57
Compare
Enzime
requested changes
Oct 30, 2024
mweinelt
force-pushed
the
node-exporter
branch
from
f349f57 to
3bada35
Compare
|
All requested changes applied. |
zowoq
reviewed
Oct 31, 2024
mweinelt
force-pushed
the
node-exporter
branch
from
ce01d4a to
6c8d45f
Compare
emilazy
approved these changes
Nov 4, 2024
Comment on lines
+98
to
+106
| script = concatStringsSep " " | ||
| ([ | ||
| (getExe cfg.package) | ||
| "--web.listen-address" | ||
| "${cfg.listenAddress}:${toString cfg.port}" | ||
| ] | ||
| ++ (map (collector: "--collector.${collector}") cfg.enabledCollectors) | ||
| ++ (map (collector: "--no-collector.${collector}") cfg.disabledCollectors) | ||
| ) + escapeShellArgs cfg.extraFlags; |
There was a problem hiding this comment.
Since we probably don’t want shell injection in the other arguments here, could just use escapeShellArgs for the whole thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module for the Prometheus Node Exporter, which I want to use in the nixos.org infra.
I will test this shortly, but it is probably good enough for a review.
Options are similar to NixOS, but I chose a different namespace, since what NixOS has is probably overkill.