Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityInterceptor rewrites the status and double-closes if other Interceptors close the call #231

Closed
jGleitz opened this issue Jul 14, 2021 · 1 comment
Labels
bug Auto-generates notes
Milestone

Comments

@jGleitz
Copy link
Contributor

jGleitz commented Jul 14, 2021

SecurityInterceptor sits outer-most in the default configuration and catches any exception coming from inner interceptors. When it catches an exception, it closes the call with UNAUTHENTICATED.

If other interceptors try to close the call early (i.e. in interceptCall, like SecurityInterceptor does per default), they will close the call and throw a StatusRuntimeException. SecurityInterceptor will catch the exception and try to close the call once again with status UNAUTHENTICATED.

From my point of view, the expected behaviour is that SecurityInterceptor does not interfere with exceptions from inner interceptors. They will usually not indicate an authentication problem.

jGleitz added a commit to jGleitz/grpc-spring-boot-starter that referenced this issue Jul 14, 2021
jGleitz added a commit to jGleitz/grpc-spring-boot-starter that referenced this issue Jul 14, 2021
jGleitz added a commit to jGleitz/grpc-spring-boot-starter that referenced this issue Jul 14, 2021
@jvmlet jvmlet added the bug Auto-generates notes label Aug 24, 2021
@jvmlet jvmlet added this to the 4.5.6 milestone Aug 24, 2021
@jvmlet jvmlet closed this as completed in 0550964 Aug 24, 2021
@jvmlet
Copy link
Collaborator

jvmlet commented Aug 26, 2021

@jGleitz , 4.5.6 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Auto-generates notes
Projects
None yet
2 participants