Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block onHalfClose if onMessage was blocked #241

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

jGleitz
Copy link
Contributor

@jGleitz jGleitz commented Sep 6, 2021

fixes #240

@jGleitz jGleitz changed the title Block onHalfClose in onMessage was blocked Block onHalfClose if onMessage was blocked Sep 6, 2021
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #241 (709affc) into master (f483d74) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     90.33%   90.43%   +0.09%     
- Complexity      212      213       +1     
============================================
  Files            38       38              
  Lines           921      930       +9     
  Branches         39       40       +1     
============================================
+ Hits            832      841       +9     
  Misses           69       69              
  Partials         20       20              
Impacted Files Coverage Δ
.../springboot/grpc/security/SecurityInterceptor.java 96.00% <ø> (ø)
...ingboot/grpc/FailureHandlingServerInterceptor.java 100.00% <100.00%> (ø)
...ingboot/grpc/validation/ValidatingInterceptor.java 100.00% <100.00%> (ø)
...onfigure/metrics/GRpcMetricsAutoConfiguration.java 90.14% <0.00%> (-1.41%) ⬇️
...grpc/autoconfigure/consul/GrpcConsulRegistrar.java 93.02% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea4434...709affc. Read the comment docs.

jvmlet
jvmlet previously requested changes Sep 13, 2021
Copy link
Collaborator

@jvmlet jvmlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make HalfCloseInterceptor abstract and don't register it as standalone interceptor

@jvmlet
Copy link
Collaborator

jvmlet commented Sep 13, 2021

Looks great, thanks @jGleitz

@jvmlet
Copy link
Collaborator

jvmlet commented Sep 13, 2021

Sorry, please discard my previous review .... Overlooked that HalfCloseInterceptor resides in test

@jvmlet jvmlet dismissed their stale review September 13, 2021 13:54

Overlooked

@jvmlet jvmlet merged commit 4b458cb into LogNet:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interceptors do not block onHalfClose if they block the message
2 participants