-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AnyBitPattern
derive work for generic structs
#101
Make AnyBitPattern
derive work for generic structs
#101
Conversation
ffef78a
to
0fd8cc8
Compare
@fu5ha you get to review this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
Not sure why this is failing on nightly tho |
Wonder if it's using the old macro expansion? Certainly the error message suggests so. Didn't you run into similar CI bogosity in #91? |
Just so I know I haven't gone nuts, here's the nightly and miri runs on my computer: https://gist.github.com/cky/f80cc8b82632bd10deaebcb1a5668172 |
Is there a way to rerun the CI? I could technically push an empty commit just to trigger one but if there's a way to actually just rerun, I'd rather not junk up the branch with empty commits. ;-) |
I'll try a close and re-open. |
@cky sorry I haven't looked at this one in ages. It seems by now there's a small conflict in a test file. Do you want to fix that up and then I think we can merge this? |
…ts-to-use-any-bit-pattern-derive
* Allow generic structs to use `AnyBitPattern` derive. * Attempt to nudge the CI into retrying.
(Note: despite the similar titles, this PR is not related to #83 at all. This PR is specific to the changes introduced in #91.)
When using
AnyBitPattern
derive, an automatic derive forZeroable
is created as well. However, the latter derive is missing generic parameters for the struct, which means you get errors like the following:The help text is worse than useless, because the suggested fix makes things worse.