Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pyndustri.pyi #73

Merged
merged 8 commits into from
Aug 18, 2024
Merged

Updated pyndustri.pyi #73

merged 8 commits into from
Aug 18, 2024

Conversation

smartycope
Copy link
Contributor

No description provided.

Lonami
Lonami reviewed Aug 17, 2024
View reviewed changes
pyndustri.pyi Outdated Show resolved Hide resolved
pyndustri.pyi Outdated Show resolved Hide resolved
pyndustri.pyi Outdated Show resolved Hide resolved
pyndustri.pyi Outdated Show resolved Hide resolved
pyndustri.pyi Outdated Show resolved Hide resolved
Lonami
Lonami reviewed Aug 18, 2024
View reviewed changes
Copy link
Owner

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I think the naming on the content like copper and such was based on the translated, displayed name to the player, and not the internal name. The internal name is already the property name, so by documenting the other, we could have both.

pyndustri.pyi Outdated Show resolved Hide resolved
pyndustri.pyi Show resolved Hide resolved
pyndustric/constants.py
@@ -81,7 +81,6 @@
"min": 2,
"xor": 2,
"atan2": 2,
"dst": 2,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did Mindustry remove this? Haven't played it in a long while.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I went through the operators and I couldn't find it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dst was renamed to len

@Lonami Lonami merged commit d461bd0 into Lonami:master Aug 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lonami Lonami Lonami left review comments

@JeanJPNM JeanJPNM JeanJPNM left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smartycope @Lonami @JeanJPNM