Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display additional info in the Deactivate Pod view for a faulted pod #30

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Display additional info in the Deactivate Pod view for a faulted pod #30

merged 2 commits into from
Apr 2, 2024

Conversation

itsmojo
Copy link
Contributor

@itsmojo itsmojo commented Mar 14, 2024

  • Add short sentence for Pod Expired, Empty Reservoir & Occlusion Detected
  • Display code value, fault description and PDM Ref code for other faults
  • Rework FaultEventCode struct to include new faultDescription var

itsmojo added 2 commits March 13, 2024 18:01
+ Add short sentence for Pod Expired, Empty Reservoir & Occlusion Detected
+ Display code value, fault description and PDM Ref code for other faults
+ Rework FaultEventCode struct to include new faultDescription var
@marionbarker
Copy link
Collaborator

Code review:
side-by-side review of OmniKit and OmniBLE
There are a few differences in the PR but nothing that should affect behavior.

Testing:
This was tested with the rPI DASH simulator under the OmniBLE version. (See LoopKit/OmniBLE#116 (comment))

I did not burn an Eros pod to test directly.

@marionbarker marionbarker requested a review from ps2 March 30, 2024 03:13
@marionbarker marionbarker merged commit 4d98bf5 into LoopKit:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants