Feature/pr9719 exp #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, I'll test it and get back to you later today, really appreciate your effort! |
|
@mustafasrepo Thanks so much for your assistance. I'll double-check whether it is ok to lose the upper projection and add some slt test to test if apache#9719 (review) could be solved, I'll merge it first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
@Lordworms I had some time. I tried to fix some o the points in my previous review. If you have time, can you please review these changes?. If these changes are ok with you. We can continue with these changes in the upstream PR also.
Also I think, this PR addresses the comment. However, I didn't verify it though.
Are these changes tested?
Are there any user-facing changes?