Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: xian statue disappear after 4 grenade hits #1561

Closed
aredfan opened this issue Sep 25, 2024 · 2 comments · Fixed by #1805
Closed

OG bug: xian statue disappear after 4 grenade hits #1561

aredfan opened this issue Sep 25, 2024 · 2 comments · Fixed by #1805
Assignees
@lahm86
Labels
OG bug A bug in original game TR2 TR3

Comments

@aredfan
Copy link
Collaborator

aredfan commented Sep 25, 2024

Regression since: 0.3
(The game crashes when reproduced on 0.2 and the OG .exe (shipped with TR2X.)

When I try the same steps with the Steam version or TR2Main - the xian statue take no damage from grenades.
@aredfan aredfan added the TRX bug A bug with TRX label Sep 25, 2024
@aredfan
Copy link
Collaborator Author

aredfan commented Sep 25, 2024 •
edited
Loading

The same thing happens on the PSX version with the statues disappearing after a few grenade hits. I'm guessing it's a OG bug.

https://www.tombraiderforums.com/showthread.php?p=8323595#post8323595

@aredfan aredfan added OG bug A bug in original game and removed TRX bug A bug with TRX labels Sep 25, 2024
@aredfan aredfan changed the title TR2X bug: xian spearman statue disappear after 4 grenade hits OG bug: xian statue disappear after 4 grenade hits Sep 25, 2024
@aredfan aredfan added the TR3 label Sep 27, 2024
@rr- rr- added the TR2 label Oct 3, 2024
@rr- rr- transferred this issue from LostArtefacts/TR2X Oct 3, 2024
@rr- rr- moved this to Ready in TRX Dev tracker Oct 10, 2024
@walkawayy
Copy link
Collaborator

I think TR2Main fixes this by checking if the target's item status is active or not in Grenade_Control.

@lahm86 lahm86 self-assigned this Nov 2, 2024
@lahm86 lahm86 mentioned this issue Nov 2, 2024
Closed
@lahm86 lahm86 moved this from Ready to In progress in TRX Dev tracker Nov 2, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 2, 2024
@lahm86
tr2/objects/grenade: test target item intelligence and status
e388c60 
This ensures grenades that hit inactive or unintelligent creatures have
no effect on the item's hit points. We continue to explode the grenade
in the creature's position though, as it's still a collidable entity.

Resolves LostArtefacts#1561.
@lahm86 lahm86 mentioned this issue Nov 2, 2024
Merged
2 tasks
@lahm86 lahm86 moved this from In progress to In review in TRX Dev tracker Nov 2, 2024
@lahm86 lahm86 closed this as completed in fc4fe98 Nov 2, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in TRX Dev tracker Nov 2, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in TRX Dev tracker Nov 2, 2024
rr- pushed a commit that referenced this issue Nov 2, 2024
@lahm86 @rr-
tr2/objects/grenade: test target item intelligence and status
9a452f9 
This ensures grenades that hit inactive or unintelligent creatures have
no effect on the item's hit points. We continue to explode the grenade
in the creature's position though, as it's still a collidable entity.

Resolves #1561.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
OG bug A bug in original game TR2 TR3
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/objects/grenade: test target item intelligence and status lahm86/TRX
4 participants
@rr- @lahm86 @walkawayy @aredfan