Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TR2X: improve screenshot support #1773

Closed
rr- opened this issue Oct 28, 2024 · 2 comments · Fixed by #1767
Closed

TR2X: improve screenshot support #1773

rr- opened this issue Oct 28, 2024 · 2 comments · Fixed by #1767
Assignees
@rr-
Labels
Enhancement Improvement of an existing feature TR2

Comments

@rr-
Copy link
Collaborator

rr- commented Oct 28, 2024

Currently 8-bit screenshots get saved as .pcx, 16-bit screenshots get saved as .tga, while 24-bit and 32-bit screenshots simply do not work at all (#1766). TR1X has the option to choose either jpg or png as the format, puts the screenshots in their own directory, and has a naming conflict resolver. We should implement all of that in TR2 as well.
@rr- rr- added Enhancement Improvement of an existing feature TR2 labels Oct 28, 2024
@rr- rr- self-assigned this Oct 28, 2024
@rr- rr- moved this to In progress in TRX Dev tracker Oct 28, 2024
@Richard-L
Copy link
Collaborator

Just out of curiosity, and I expect the answer to be "no", but: Do either of these vintage formats offer any advantage over PNG?

rr- added a commit that referenced this issue Oct 28, 2024
@rr-
tr2/screenshots: improve screenshots support
da94642 
Resolves #1766.
Resolves #1773.
@rr-
Copy link
Collaborator Author

rr- commented Oct 28, 2024

No, it's just pixel data.

rr- added a commit that referenced this issue Oct 28, 2024
@rr-
tr2/screenshots: improve screenshots support
e7eed55 
Resolves #1766.
Resolves #1773.
rr- added a commit that referenced this issue Oct 29, 2024
@rr-
tr2/screenshots: improve screenshots support
99d51c1 
Resolves #1766.
Resolves #1773.
rr- added a commit that referenced this issue Oct 29, 2024
@rr-
tr2/screenshots: improve screenshots support
ae3ef5d 
Resolves #1766.
Resolves #1773.
rr- added a commit that referenced this issue Oct 29, 2024
@rr-
tr2/screenshots: improve screenshots support
5d8af95 
Resolves #1766.
Resolves #1773.
@aredfan aredfan linked a pull request Oct 29, 2024 that will close this issue
tr2/decomp: fix windowed screenshots not working #1767
Merged
2 tasks
@rr- rr- closed this as completed in f8efbc9 Oct 29, 2024
@rr- rr- closed this as completed in #1767 Oct 29, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rr- rr-

Labels
Enhancement Improvement of an existing feature TR2
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/decomp: fix windowed screenshots not working LostArtefacts/TRX
2 participants
@rr- @Richard-L