Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRX bug: old custom levels cause floor data parsing issues #2114

Closed
lahm86 opened this issue Dec 24, 2024 · 0 comments · Fixed by #2120
Closed

TRX bug: old custom levels cause floor data parsing issues #2114

lahm86 opened this issue Dec 24, 2024 · 0 comments · Fixed by #2120
Assignees
Labels
TR1 TRX bug A bug with TRX

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Dec 24, 2024

Old levels that seem to have been built with Dxtre3d sometimes have multiple triggers defined for a sector (which is technically invalid). See about adding backwards compatibility for this.
Ref: #2112

@lahm86 lahm86 added TRX bug A bug with TRX TR1 labels Dec 24, 2024
@lahm86 lahm86 self-assigned this Dec 24, 2024
@lahm86 lahm86 moved this to Ready in TRX Dev tracker Dec 24, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 26, 2024
This will handle cases in old levels where a sector has multiple
trigger entries. Officially only one is supported, but it seems old
levels use this approach to add dummy triggers for such things as
bridges on top of pre-existing triggers. This would have worked with
the old g_TriggerIndex approach because of the way floor height tests
were performed. Instead now, if we detect a trigger but the sector
already has one, we simply append the new commands onto the existing
trigger.

Resolves LostArtefacts#2114.
@lahm86 lahm86 moved this from Ready to In progress in TRX Dev tracker Dec 26, 2024
@lahm86 lahm86 closed this as completed in d016288 Dec 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1 TRX bug A bug with TRX
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant