Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: fix hidden ammo counter while demo plays in NG+ #1776

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

walkawayy
Copy link
Collaborator

Resolves #1559.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fix the ammo counter being hidden while a demo plays in NG+. Institutes a similar groundwork as TR1X which stores and restores config options that can mess with demos.

@walkawayy walkawayy added the OG bug A bug in original game label Oct 30, 2024
@walkawayy walkawayy self-assigned this Oct 30, 2024
@walkawayy walkawayy requested review from a team as code owners October 30, 2024 00:42
@walkawayy walkawayy requested review from rr- and lahm86 and removed request for a team October 30, 2024 00:42
Copy link

@rr- rr- added the TR2 label Oct 30, 2024
@Richard-L
Copy link
Collaborator

I'm confused, isn't there no ammo limit in NG+ and hence it's not showing?

Or are you intending to show the regular demo, regardless of whether NG+ has been unlocked or not?

Are you also adapting the damage Lara does?

@aredfan aredfan self-requested a review October 30, 2024 07:20
@rr-
Copy link
Collaborator

rr- commented Oct 30, 2024

I'm confused, isn't there no ammo limit in NG+ and hence it's not showing?

No

Or are you intending to show the regular demo, regardless of whether NG+ has been unlocked or not?

This

Are you also adapting the damage Lara does?

Yes

@rr- rr- merged commit 393ffcb into LostArtefacts:develop Oct 30, 2024
6 checks passed
@walkawayy walkawayy deleted the issue-1559-demo-ammo branch November 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OG bug: ammo counter is hidden if a demo plays while new game+ is active
4 participants