stats: fix the game hanging if exited during the level stats, credits, or final stats

[walkawayy]

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fix the game hanging if exited during the level stats, credits, or final stats.

The only caveat to this PR is that if you exit during the credit images (not the final stats), the game has to wait until the current credits picture timer ends before it will exit. I think this is due to the credit pictures being unskippable which is a separate issue. I hate to bug @rr-, but if we could get DisplayCredits decompiled, I think we could solve this delayed exit and unskippable credits in another PR. There is no rush on this though, so I don't mind marking this PR as draft until we have to time to decompile DisplayCredits.

[github-actions]

Download the built assets for this pull request:

• TR1X-4.5.1-127-g1a29a29-linux.zip
• TR1X-4.5.1-127-g1a29a29-win.zip
• TR2X-0.5-156-g1a29a29-win.zip
• TR1X-4.5.1-127-g1a29a29-win-installer.zip

[rr-]

I can decompile the necessary functions after we merge #1768.

[rr-]

@walkawayy actually you just need this:

diff --git a/src/tr2/decomp/decomp.c b/src/tr2/decomp/decomp.c
index 990a0e87..38cc00a3 100644
--- a/src/tr2/decomp/decomp.c
+++ b/src/tr2/decomp/decomp.c
@@ -560,7 +560,8 @@ void __cdecl Shell_Shutdown(void)
 {
     Console_Shutdown();
     WinInFinish();
-    RenderFinish(true);
+    BGND_Free();
+    RenderFinish(false);
     WinVidFinish();
     WinVidHideGameWindow();
     if (g_ErrorMessage[0]) {
@@ -3068,6 +3069,10 @@ void __cdecl S_Wait(int32_t frames, const BOOL input_check)
                 passed = Sync();
             } while (!passed);
             frames -= passed;
+
+            if (g_IsGameToExit) {
+                break;
+            }
         }
     }
 
@@ -3077,6 +3082,10 @@ void __cdecl S_Wait(int32_t frames, const BOOL input_check)
             break;
         }
 
+        if (g_IsGameToExit) {
+            break;
+        }
+
         int32_t passed;
         do {
             passed = Sync();

[lahm86]

LGTM. Thanks for fixing, this was always an annoying bug.